Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23838 )
Change subject: IMPALA-14564: Remove redundant partition info from Iceberg file descriptors ...................................................................... Patch Set 8: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23838/8/common/fbs/CatalogObjects.fbs File common/fbs/CatalogObjects.fbs: PS8: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/23838/8/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: PS8: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/23838/8/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/23838/8/common/thrift/CatalogObjects.thrift@681 PS8, Line 681: 9: optional list<binary> partitions Changing type of field 'partitions' from list<TIcebergPartition> to list<binary> in TIcebergContentFileStore might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/23838/8/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23838/8/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@215 PS8, Line 215: FbIcebergMetadata icebergMetadata = clonedFd.getFbFileMetadata().icebergMetadata(); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c2fd6f1ebb636aa9e7ca925413ca51858cbc2a Gerrit-Change-Number: 23838 Gerrit-PatchSet: 8 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 18 May 2026 11:02:25 +0000 Gerrit-HasComments: Yes
