Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23838 )
Change subject: IMPALA-14564: Remove redundant partition info from Iceberg file descriptors ...................................................................... Patch Set 10: Code-Review+1 (1 comment) LGTM! http://gerrit.cloudera.org:8080/#/c/23838/10/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23838/10/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@213 PS10, Line 213: // We create a deep copy of the file descriptor for cache consistency. : IcebergFileDescriptor clonedFd = fd.deepCopy(); Should we have a quick check to see if partId and firstRowId need modification at all? -- To view, visit http://gerrit.cloudera.org:8080/23838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c2fd6f1ebb636aa9e7ca925413ca51858cbc2a Gerrit-Change-Number: 23838 Gerrit-PatchSet: 10 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 18 May 2026 16:31:42 +0000 Gerrit-HasComments: Yes
