Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23996 )
Change subject: IMPALA-13464: Add STORED AS CSV and TSV syntactic sugar ...................................................................... Patch Set 6: (2 comments) > (3 comments) > > Thanks for taking this up! Thank you for the review! I have updated the commit message to sound much better. Also, I have added the support for TSV now. I have yet to add the tests. The `action code` routines used here were newly added. The variables declared inside are structured within an inner class of the parser, and can be accessed or changed globally (within the parser). Because of this new routine, I was told by Noemi to await a proper parser code review. The only other approach I could find involved making 'file_format_val' result a pair instead of a single value, which feels unnecessary, so I have yet to add the tests. Please let me know what you think. http://gerrit.cloudera.org:8080/#/c/23996/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23996/5//COMMIT_MSG@9 PS5, Line 9: yntacti > nit: "tables" Done http://gerrit.cloudera.org:8080/#/c/23996/5//COMMIT_MSG@23 PS5, Line 23: Both 'CSV' and 'TSV' have been added as valid `file_format_val` keywords. > Please add parser and e2e tests for CreateTable, CreateTableAsSelect, Alter Done -- To view, visit http://gerrit.cloudera.org:8080/23996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5ef21e7b2029314ac772b3465cac20a8a0d9a7b Gerrit-Change-Number: 23996 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 18 May 2026 17:20:51 +0000 Gerrit-HasComments: Yes
