Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/23996 )
Change subject: IMPALA-13464: Add STORED AS CSV and TSV syntactic sugar ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23996/6/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/23996/6/fe/src/main/cup/sql-parser.cup@321 PS6, Line 321: action code {: I think using global vars to store this kind of information is not the best way to implement this. Instead we could introduce a non-terminal that contains both values in a Pair. nonterminal Pair<THdfsFileFormat, RowFormat> file_format_create_table_val; | KW_STORED KW_AS KW_CSV {: RESULT = new Pair<>(THdfsFileFormat.TEXT, new RowFormat(",", null, "\\")); :} | KW_STORED KW_AS KW_TSV {: RESULT = new Pair<>(THdfsFileFormat.TEXT, new RowFormat("\t", null, "\\")); :} -- To view, visit http://gerrit.cloudera.org:8080/23996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5ef21e7b2029314ac772b3465cac20a8a0d9a7b Gerrit-Change-Number: 23996 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 21 May 2026 14:17:56 +0000 Gerrit-HasComments: Yes
