Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/24296/6/tests/metadata/test_last_ddl_time_update.py File tests/metadata/test_last_ddl_time_update.py: http://gerrit.cloudera.org:8080/#/c/24296/6/tests/metadata/test_last_ddl_time_update.py@32 PS6, Line 32: if cls.exploration_strategy() != 'exhaustive' and not IS_S3: > nit: could probably be a @SkipIf condition. I would prefer to keep it as it is for now. There could be another patch "SkipIf rationalization" that replaces common skip conditions with SkipIf I plan to do this for setup_class(cls) functions that do nothing else than call super and skip if not exhaustive, but could add some other changes too. http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_io_metrics.py File tests/query_test/test_io_metrics.py: http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_io_metrics.py@53 PS6, Line 53: query_options={'num_nodes': 1}) > Does this effectively change the test? Yes, now the num_nodes=1 is actually applied to the test. I agree with the original intention of making the test more stable this way. -- To view, visit http://gerrit.cloudera.org:8080/24296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132 Gerrit-Change-Number: 24296 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 11:46:46 +0000 Gerrit-HasComments: Yes
