Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests ...................................................................... IMPALA-14985: Cleanup tests with unused 'vector' in EE tests Having 'vector' argument leads to running a test as parametrized, so running it with multiple parameter vectors. These parameters don't affect how queries run unless passed to functions like run_test_case() explicitly. Note that unused 'vector's can give the false impression of affecting the query options of queries run by default clients as query option CLIENT_IDENTIFIER is actually modifed based on the parameter vector using pytest hook pytest_runtest_logstart and connections' clear_configuration and create_connection functions. One example (TestIOMetrics) was found where the intention was to pass num_nodes=1 but this didn't happen. A test bug found during this change is that there were test classes where "skip if not exhaustive" logic was implemented within add_test_dimensions(), but this didn't affect non-parametrized tests that were still run in core builds. This is fixed by checking exploration strategy elsewhere. The change also cleans up add_test_dimensions() functions which are not used as the test class has no test function with 'vector' parameter. Testing: - passed exhaustive tests Generated by: copilot + Claude Sonnet 4.6 Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132 Reviewed-on: http://gerrit.cloudera.org:8080/24296 Reviewed-by: Noemi Pap-Takacs <[email protected]> Tested-by: Csaba Ringhofer <[email protected]> --- M tests/catalog_service/test_catalog_service_client.py M tests/catalog_service/test_large_num_partitions.py M tests/custom_cluster/test_codegen_cache.py M tests/custom_cluster/test_custom_statestore.py M tests/custom_cluster/test_disable_features.py M tests/custom_cluster/test_external_planner.py M tests/custom_cluster/test_hedged_reads.py M tests/custom_cluster/test_iceberg_strict_data.py M tests/custom_cluster/test_jvm_mem_tracking.py M tests/custom_cluster/test_krpc_mem_usage.py M tests/custom_cluster/test_krpc_metrics.py M tests/custom_cluster/test_krpc_options.py M tests/custom_cluster/test_parquet_max_page_header.py M tests/custom_cluster/test_partition.py M tests/custom_cluster/test_permanent_udfs.py M tests/custom_cluster/test_query_log.py M tests/custom_cluster/test_scheduler_locality.py M tests/custom_cluster/test_shared_tzdb.py M tests/custom_cluster/test_sys_db.py M tests/custom_cluster/test_tuple_cache.py M tests/custom_cluster/test_udf_concurrency.py M tests/metadata/test_compute_stats.py M tests/metadata/test_hdfs_permissions.py M tests/metadata/test_hms_integration.py M tests/metadata/test_last_ddl_time_update.py M tests/metadata/test_load.py M tests/metadata/test_metadata_query_statements.py M tests/metadata/test_partition_metadata.py M tests/metadata/test_recover_partitions.py M tests/metadata/test_recursive_listing.py M tests/metadata/test_refresh_partition.py M tests/metadata/test_reuse_partitions.py M tests/metadata/test_show_create_table.py M tests/metadata/test_stale_metadata.py M tests/metadata/test_testcase_builder.py M tests/metadata/test_views_compatibility.py M tests/query_test/test_acid.py M tests/query_test/test_avro_schema_resolution.py M tests/query_test/test_cast_with_format.py M tests/query_test/test_codegen.py M tests/query_test/test_compressed_formats.py M tests/query_test/test_ext_data_sources.py M tests/query_test/test_fetch.py M tests/query_test/test_insert.py M tests/query_test/test_insert_parquet.py M tests/query_test/test_io_metrics.py M tests/query_test/test_join_queries.py M tests/query_test/test_query_opts.py M tests/stress/test_acid_stress.py M tests/stress/test_ddl_stress.py M tests/stress/test_insert_stress.py M tests/stress/test_merge_stress.py M tests/stress/test_update_stress.py M tests/unittests/test_result_verifier.py 54 files changed, 79 insertions(+), 372 deletions(-) Approvals: Noemi Pap-Takacs: Looks good to me, approved Csaba Ringhofer: Verified -- To view, visit http://gerrit.cloudera.org:8080/24296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132 Gerrit-Change-Number: 24296 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
