Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 13: (6 comments) Added limit of 3 concurrent profile analysis runs http://gerrit.cloudera.org:8080/#/c/24284/12/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/12/be/src/service/query-profile-ai-analysis.cc@480 PS12, Line 480: "required": [] > Let's add DCHECK(response_doc != nullptr); Done http://gerrit.cloudera.org:8080/#/c/24284/12/be/src/service/query-profile-ai-analysis.cc@490 PS12, Line 490: "type": "object", : "properties": {}, : "required": [] > Instead of creating a new string, get a string_view from the substring and Done http://gerrit.cloudera.org:8080/#/c/24284/12/be/src/service/query-profile-ai-analysis.cc@519 PS12, Line 519: content(std::move(content) > Since this is an internal-only function and all calls to this function have Done http://gerrit.cloudera.org:8080/#/c/24284/12/be/src/service/query-profile-ai-analysis.cc@520 PS12, Line 520: tool_call_id(std::move(tool_call_id)), > Let's add DCHECK(assistant_content != nullptr); Done http://gerrit.cloudera.org:8080/#/c/24284/12/be/src/service/query-profile-ai-analysis.cc@746 PS12, Line 746: tracker.Close(); : return Status::OK(); : } : > Nit: can we pull all the JSON keys like "role", "content", "tool_calls", "f Done http://gerrit.cloudera.org:8080/#/c/24284/12/be/src/service/query-profile-ai-analysis.cc@762 PS12, Line 762: ppend(ANALYSIS_PR > Does a new string need to be initialized here or can the tool_name string_v Passed a non-owning view-compatible type instead: StringPiece(tool_name.data(), static_cast<int>(tool_name.size())), so no extra string allocation is needed there. -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 13 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 22:18:25 +0000 Gerrit-HasComments: Yes
