Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/24284/12/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/12/be/src/service/query-profile-ai-analysis.cc@746 PS12, Line 746: if (function.HasMember("arguments") && function["arguments"].IsString()) { : const Value& arguments = function["arguments"]; : args_json = string_view(arguments.GetString(), arguments.GetStringLength()); : } Nit: can we pull all the JSON keys like "role", "content", "tool_calls", "function", "arguments", "assistant", "name" and "id" out into static constexpr const char[] constants? -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 12 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2026 21:43:24 +0000 Gerrit-HasComments: Yes
