Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/24284/16/be/src/service/query-profile-ai-analysis.h File be/src/service/query-profile-ai-analysis.h: http://gerrit.cloudera.org:8080/#/c/24284/16/be/src/service/query-profile-ai-analysis.h@30 PS16, Line 30: Status CallAiGenerateText(std::string_view impala_options_json, std::string* response); : : using AiToolExecutor = std::function<Status( : std::string_view tool_name, std::string_view tool_args_json, std::string* tool_json)>; : : Status RunAiAgentWithToolExecutor(std::string_view initial_summary_json, : const AiToolExecutor& tool_executor, std::string* analysis); : : Status GenerateAiAnalysisFromProfile( : std::string_view profile_text, std::string* analysis); Please add some comments describing the functions -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 16 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2026 03:26:33 +0000 Gerrit-HasComments: Yes
