Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24284 )
Change subject: IMPALA-14963: Query Profile AI Analysis Tool ...................................................................... Patch Set 21: (8 comments) http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/impala-http-handler.cc@460 PS20, Line 460: : > Define a helper at the beginning of this function to de duplicate error han Done http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/impala-http-handler.cc@479 PS20, Line 479: if (!status.ok()) return set_error(status.GetDetail()); : : Value query_id(PrintId(unique_id), do > Update GenerateAiAnalysisFromProfile to accept JSON DOM by reference to pre Done http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/impala-http-handler.cc@496 PS20, Line 496: document->GetAllocator()); : > Prefer StringRef for literals: Done http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis-test.cc File be/src/service/query-profile-ai-analysis-test.cc: http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis-test.cc@140 PS20, Line 140: EXPECT_EQ(nullptr, assistant_message); > Add test case to ensure ReleaseAiAnalysisSlot() cannot cause num_profiles_b Done http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis-test.cc@141 PS20, Line 141: } : : TEST(QueryProfileAiAnalysisHelpersTest, MaxConcurrentSlots > Use a ScopedFlagSetter to manage this flag's value. Done http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis.cc File be/src/service/query-profile-ai-analysis.cc: http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis.cc@79 PS20, Line 79: using namespace std; : : namespace impala { > replace with using namespace std; Done http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis.cc@87 PS20, Line 87: const > Remove "std::" prefixes Done http://gerrit.cloudera.org:8080/#/c/24284/20/be/src/service/query-profile-ai-analysis.cc@133 PS20, Line 133: } > Add an if statement to ensure num_profiles_being_analyzed > 0 before decrem Done -- To view, visit http://gerrit.cloudera.org:8080/24284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9376b8c56df75032f51abbb76b3ac6927f9107e Gerrit-Change-Number: 24284 Gerrit-PatchSet: 21 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2026 20:04:02 +0000 Gerrit-HasComments: Yes
