Pranav Lodha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24300 )

Change subject: IMPALA-3451: Long comments should not break queries
......................................................................


Patch Set 7:

(2 comments)

> Patch Set 7: Commit message was updated.

http://gerrit.cloudera.org:8080/#/c/24300/5/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java
File fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java:

http://gerrit.cloudera.org:8080/#/c/24300/5/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java@61
PS5, Line 61: accepts for [serde] property keys.
> Update comment please.
Done


http://gerrit.cloudera.org:8080/#/c/24300/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/24300/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4800
PS5, Line 4800:     AnalyzesOk(String.format("comment on database functional is 
'%s'",
              :         StringUtils.repeat("a", 500)));
> The referenced Hive patch is only about incrementing the size of column com
Ack



--
To view, visit http://gerrit.cloudera.org:8080/24300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib49dd40ddf1c280c4be9728e096d9cf039c7def2
Gerrit-Change-Number: 24300
Gerrit-PatchSet: 7
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 21 May 2026 13:01:45 +0000
Gerrit-HasComments: Yes

Reply via email to