Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24300 )
Change subject: IMPALA-3451: Update the maximum length of comments ...................................................................... Patch Set 8: Code-Review+2 (1 comment) LGTM. Carrying Zoltan's +1. http://gerrit.cloudera.org:8080/#/c/24300/2/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java File fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java: http://gerrit.cloudera.org:8080/#/c/24300/2/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java@62 PS2, Line 62: public static final int MAX_PROPERTY_KEY_LENGTH = 256; > Done When running on Apache Hive 2.x and 3.x, the DDL will fail in HMS side due to shorter limit there. But I think it's fine. We can move this to shims in future patches, or probably using constants from the Hive repo. -- To view, visit http://gerrit.cloudera.org:8080/24300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib49dd40ddf1c280c4be9728e096d9cf039c7def2 Gerrit-Change-Number: 24300 Gerrit-PatchSet: 8 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 27 May 2026 13:40:26 +0000 Gerrit-HasComments: Yes
