Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24133 )
Change subject: IMPALA-14523: JDBC Scan Parallelism with Shared Cursor Fetching ...................................................................... Patch Set 11: (11 comments) > Uploaded patch set 11. http://gerrit.cloudera.org:8080/#/c/24133/10/be/src/exec/data-source-scan-node.h File be/src/exec/data-source-scan-node.h: http://gerrit.cloudera.org:8080/#/c/24133/10/be/src/exec/data-source-scan-node.h@181 PS10, Line 181: scan n > nit: thread => scan node. Done http://gerrit.cloudera.org:8080/#/c/24133/10/be/src/exec/data-source-scan-node.cc File be/src/exec/data-source-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/24133/10/be/src/exec/data-source-scan-node.cc@93 PS10, Line 93: const extdatasource::TOpen > Could be const &? Done http://gerrit.cloudera.org:8080/#/c/24133/10/be/src/exec/data-source-scan-node.cc@265 PS10, Line 265: izes the > There is no fetch_mu_ Done http://gerrit.cloudera.org:8080/#/c/24133/10/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/24133/10/be/src/scheduling/scheduler.cc@1183 PS10, Line 1183: = std::hash<int>{}(node_id) % all_execs.si > std::hash<int> returns size_t (unsigned), if you cast it to int it might be Done http://gerrit.cloudera.org:8080/#/c/24133/10/common/thrift/ExternalDataSource.thrift File common/thrift/ExternalDataSource.thrift: http://gerrit.cloudera.org:8080/#/c/24133/10/common/thrift/ExternalDataSource.thrift@153 PS10, Line 153: } > Revert this file Done http://gerrit.cloudera.org:8080/#/c/24133/10/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/24133/10/common/thrift/PlanNodes.thrift@387 PS10, Line 387: } > Remove empty line Done http://gerrit.cloudera.org:8080/#/c/24133/6/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/24133/6/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@209 PS6, Line 209: rowBatch = iterator_.fetchBatch(scalarTypes_, batchSize_); > No need to initialize here. Done http://gerrit.cloudera.org:8080/#/c/24133/10/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/24133/10/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@490 PS10, Line 490: case VARCHAR: > Should we add VARCHAR as well? Done http://gerrit.cloudera.org:8080/#/c/24133/10/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@501 PS10, Line 501: * Return Impala-to-X column mapping, or empty if it is not set. : * : */ > At this point colData.Is_null() has an element corresponding to the actual Done http://gerrit.cloudera.org:8080/#/c/24133/10/testdata/workloads/functional-planner/queries/PlannerTest/jdbc-parallel.test File testdata/workloads/functional-planner/queries/PlannerTest/jdbc-parallel.test: http://gerrit.cloudera.org:8080/#/c/24133/10/testdata/workloads/functional-planner/queries/PlannerTest/jdbc-parallel.test@3577 PS10, Line 3577: LEFT JOI > To these tests, MT_DOP only affects the joins, i.e. a JOIN BUILD fragment a Done http://gerrit.cloudera.org:8080/#/c/24133/10/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/24133/10/tests/custom_cluster/test_ext_data_sources.py@1037 PS10, Line 1037: TestJdbcMtDop > What is the duration of executing this test suite? Done -- To view, visit http://gerrit.cloudera.org:8080/24133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b25b99f5cb77d32c111ba37c0a01378ffdc1107 Gerrit-Change-Number: 24133 Gerrit-PatchSet: 11 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 21 May 2026 15:32:05 +0000 Gerrit-HasComments: Yes
