Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24133 )
Change subject: IMPALA-14523: JDBC Scan Parallelism with Shared Cursor Fetching ...................................................................... Patch Set 11: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24133/11/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/24133/11/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@159 PS11, Line 159: // Opaque handle returned to the caller and used in subsequent getNext()/close() calls. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24133/11/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/24133/11/tests/custom_cluster/test_ext_data_sources.py@1070 PS11, Line 1070: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/24133/11/tests/custom_cluster/test_ext_data_sources.py@1070 PS11, Line 1070: # Correctness line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/24133/11/tests/custom_cluster/test_ext_data_sources.py@1268 PS11, Line 1268: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/24133/11/tests/custom_cluster/test_ext_data_sources.py@1268 PS11, Line 1268: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/24133/11/tests/custom_cluster/test_ext_data_sources.py@1269 PS11, Line 1269: d flake8: E304 blank lines found after function decorator -- To view, visit http://gerrit.cloudera.org:8080/24133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b25b99f5cb77d32c111ba37c0a01378ffdc1107 Gerrit-Change-Number: 24133 Gerrit-PatchSet: 11 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 21 May 2026 15:32:40 +0000 Gerrit-HasComments: Yes
