Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10816 )
Change subject: IMPALA-5981: [DOCS] Documented SET="" ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10816/1/docs/topics/impala_set.xml File docs/topics/impala_set.xml: http://gerrit.cloudera.org:8080/#/c/10816/1/docs/topics/impala_set.xml@57 PS1, Line 57: <p rev="2.11.0 IMPALA-2181"> This looks like an improvement overall. One thing that I think we could improve is distinguishing between the impala-shell set/unset commands and the server-side set command. impala-shell intercepts all set commands and handles them locally - it's impossible to run the same set command that a JDBC driver or similar would use. The syntax is slightly different, e.g. unset only works in impala-shell and I think some of the quoting might be a bit different. I also can't remember if set var="" in impala-shell behaves the same as unset var - I don't have a cluster right now to check. I'm open to doing this as a follow-up but seems like it might be easiest to fix it while we're here. -- To view, visit http://gerrit.cloudera.org:8080/10816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7211405d5cc0a548c05ea5218798591873c14417 Gerrit-Change-Number: 10816 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 27 Jun 2018 00:40:21 +0000 Gerrit-HasComments: Yes
