Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10816 )
Change subject: IMPALA-5981: [DOCS] Documented SET="" ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10816/1/docs/topics/impala_set.xml File docs/topics/impala_set.xml: http://gerrit.cloudera.org:8080/#/c/10816/1/docs/topics/impala_set.xml@57 PS1, Line 57: <p rev="2.11.0 IMPALA-2181"> > After checking the impala-shell command and start option doc, I removed imp The other difference between the two sets is that the SQL set has quotes around the strings SQL: set foo="bar"; set foo=""; Shell: set foo=bar; unset foo; http://gerrit.cloudera.org:8080/#/c/10816/2/docs/topics/impala_set.xml File docs/topics/impala_set.xml: http://gerrit.cloudera.org:8080/#/c/10816/2/docs/topics/impala_set.xml@142 PS2, Line 142: </p> This is true for any interface that isn't impala-shell, e.g. Hue. Remove the qualification here? -- To view, visit http://gerrit.cloudera.org:8080/10816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7211405d5cc0a548c05ea5218798591873c14417 Gerrit-Change-Number: 10816 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Jun 2018 23:22:19 +0000 Gerrit-HasComments: Yes