Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24337 )
Change subject: IMPALA-14954: Support ADMIN OPTION clause for GRANT/REVOKE ROLE ...................................................................... Patch Set 5: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24337/5/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: http://gerrit.cloudera.org:8080/#/c/24337/5/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1904 PS5, Line 1904: testToSql(ctx, String.format("GRANT ROLE %s TO GROUP %s WITH ADMIN OPTION", testRole, testGroup)); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/24337/5/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1906 PS5, Line 1906: testToSql(ctx, String.format("GRANT ROLE %s TO USER %s WITH ADMIN OPTION", testRole, testUser)); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/24337/5/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1908 PS5, Line 1908: testToSql(ctx, String.format("REVOKE ADMIN OPTION FOR %s FROM GROUP %s", testRole, testGroup)); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/24337/5/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@1910 PS5, Line 1910: testToSql(ctx, String.format("REVOKE ADMIN OPTION FOR %s FROM USER %s", testRole, testUser)); line too long (99 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7c9ba091bc15271c7a3ef34ca06a38630d5bb6 Gerrit-Change-Number: 24337 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 18:38:53 +0000 Gerrit-HasComments: Yes
