Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24337 )
Change subject: IMPALA-14954: Support ADMIN OPTION clause for GRANT/REVOKE ROLE ...................................................................... Patch Set 6: (1 comment) In patch set 6 I fixed the following issues in patch set 4. - Wrong syntax as pointed out at https://gerrit.cloudera.org/c/24337/4/tests/authorization/test_ranger.py#2367. - ToSqlTest#testGrantRevokeRoleStmt(). http://gerrit.cloudera.org:8080/#/c/24337/4/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/24337/4/tests/authorization/test_ranger.py@2367 PS4, Line 2367: self.create_impala_client(user=ADMIN) as admin_client: The syntax is not correct unless we are using Python of a newer version, e.g., 3.10. We should remove the pair of parenthesis. -- To view, visit http://gerrit.cloudera.org:8080/24337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7c9ba091bc15271c7a3ef34ca06a38630d5bb6 Gerrit-Change-Number: 24337 Gerrit-PatchSet: 6 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 18:41:16 +0000 Gerrit-HasComments: Yes
