Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24353 )
Change subject: IMPALA-12956: Add profile summary output ...................................................................... Patch Set 5: > Patch Set 5: > > Thanks for the review, Quanlong. PS5 addresses the comments: added failed and > cancelled query coverage for missing End Time, Query Status truncation, and > partial TExecSummary.progress; fixed the indentation nit; moved > ProgressToString from ImpalaHttpHandler to util/summary-util and reused it in > both the Web UI JSON path and impala-profile-tool; changed duration to prefer > End Time minus Start Time with Query Timeline fallback; replaced the custom > memory parser with ParseUtil::ParseMemSpec while keeping empty or malformed > values as N/A; added total scan-range extraction from File Formats for both > V1 and V2 profiles; added Query Status as a truncated summary column; and > kept missing or empty summary fields as N/A. Validation: macOS git diff > --check, py_compile, and touched-file 90-col check; VM git diff --check, make > -C be/src/util impala-profile-tool, bin/impala-py.test -q > tests/observability/test_profile_tool.py with 9 passed, make -C be/src/util > summary-util-test, ProgressToStringTest.*, and make -C be/src/service > unifiedbetests. Jenkins initial checks also passed on PS5: > https://jenkins.impala.io/job/gerrit-code-review-checks/22625/ Thank Aleksandr! I'll review the new patch set soon. BTW, you can reply each comment individually by inline comments: https://gerrit.cloudera.org/Documentation/user-review-ui.html#inline-comments -- To view, visit http://gerrit.cloudera.org:8080/24353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35da958106ffb35b14ef867da50ed23ffda0a45b Gerrit-Change-Number: 24353 Gerrit-PatchSet: 5 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 01:26:27 +0000 Gerrit-HasComments: No
