Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24353 )
Change subject: IMPALA-12956: Add profile summary output ...................................................................... Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/24353/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24353/6//COMMIT_MSG@24 PS6, Line 24: Done in PS5. Added focused failed and cancelled summary-output coverage, including missing End Time, partial progress from TExecSummary.progress, and truncated Query Status. http://gerrit.cloudera.org:8080/#/c/24353/6/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24353/6/be/src/util/impala-profile-tool.cc@239 PS6, Line 239: } Done in PS5. http://gerrit.cloudera.org:8080/#/c/24353/6/be/src/util/impala-profile-tool.cc@254 PS6, Line 254: return SumAggregatedCounterValues(tree, "ScratchBytesWritten", value); Done in PS5. Moved ProgressToString() to be/src/util/summary-util.* and reused it from both impala-profile-tool and the WebUI JSON path. http://gerrit.cloudera.org:8080/#/c/24353/6/be/src/util/impala-profile-tool.cc@281 PS6, Line 281: if (timestamp.empty()) return false; Done in PS5. QueryDuration() now prefers End Time - Start Time and falls back to Query Timeline when End Time is missing or cannot be parsed. http://gerrit.cloudera.org:8080/#/c/24353/6/be/src/util/impala-profile-tool.cc@304 PS6, Line 304: && std::isdigit(static_cast<unsigned char>(timestamp[i])) Done in PS5. ParseBytesValue() now normalizes whitespace and calls ParseUtil::ParseMemSpec(); invalid values and percentages still report N/A. http://gerrit.cloudera.org:8080/#/c/24353/6/be/src/util/impala-profile-tool.cc@378 PS6, Line 378: char* count_end = nullptr; Done in PS5. Added total scan-range extraction from File Formats. V1 profile logs sum only under Instance subtrees; V2 aggregated profiles multiply each distinct value by the contributing instance count. http://gerrit.cloudera.org:8080/#/c/24353/6/be/src/util/impala-profile-tool.cc@390 PS6, Line 390: Done in PS5. ScanProgress() and QueryProgress() now use TExecSummary.progress when it is present, so failed/cancelled profiles can show partial progress. The finished-query fallback remains only for older FINISHED profiles without total scan ranges. http://gerrit.cloudera.org:8080/#/c/24353/6/be/src/util/impala-profile-tool.cc@461 PS6, Line 461: } Done in PS5. GetInfoString() now accepts a default value, and summary output uses N/A for missing End Time. http://gerrit.cloudera.org:8080/#/c/24353/6/be/src/util/impala-profile-tool.cc@471 PS6, Line 471: } Done in PS5. Added Query Status as a truncated summary column, using the same summary_stmt_length behavior as Sql Statement. -- To view, visit http://gerrit.cloudera.org:8080/24353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35da958106ffb35b14ef867da50ed23ffda0a45b Gerrit-Change-Number: 24353 Gerrit-PatchSet: 6 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 12:35:20 +0000 Gerrit-HasComments: Yes
