Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24208 )
Change subject: IMPALA-14903: Calcite planner: Simplify code for string literals ...................................................................... Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/24208/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24208/7//COMMIT_MSG@58 PS7, Line 58: (select 1 a, 3 b union all select 1 a, 3 b) z on z.b = y.b; nit: we can add this as a regression test. http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@78 PS7, Line 78: * has the correction functions. nit: the comment seems stale. http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@64 PS7, Line 64: * to match its input type. nit: the comment seems stale http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@118 PS7, Line 118: if (isImplicitCharCastOfLiteral(call)) { Do we still need this? visitLiteral() has been removed and the above comment seems stale. http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java: http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java@77 PS7, Line 77: if nit: use "else if" ? http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaRexExecutor.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaRexExecutor.java: http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaRexExecutor.java@48 PS7, Line 48: import org.apache.impala.util.StringUtils; nit: unused http://gerrit.cloudera.org:8080/#/c/24208/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaRexExecutor.java@52 PS7, Line 52: import java.nio.ByteBuffer; nit: unused http://gerrit.cloudera.org:8080/#/c/24208/7/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test: http://gerrit.cloudera.org:8080/#/c/24208/7/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test@a154 PS7, Line 154: Is this a perf regression? Now we need to materialize both children. -- To view, visit http://gerrit.cloudera.org:8080/24208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8e61b2555afd81ef52f19431fdd1224d4039c00 Gerrit-Change-Number: 24208 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 29 May 2026 09:01:40 +0000 Gerrit-HasComments: Yes
