Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24208 )
Change subject: IMPALA-14903: Calcite planner: Simplify code for string literals ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/24208/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24208/7//COMMIT_MSG@58 PS7, Line 58: (select 1 a, 3 b union all select 1 a, 3 b) z on z.b = y.b; > This test is already in inline-view.test Ack http://gerrit.cloudera.org:8080/#/c/24208/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/24208/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@51 PS8, Line 51: import java.math.BigDecimal; nit: unused now http://gerrit.cloudera.org:8080/#/c/24208/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java: http://gerrit.cloudera.org:8080/#/c/24208/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexLiteralConverter.java@99 PS8, Line 99: ImpalaTypeConverter.createImpalaType(rexLiteral.getType()), false); Does this mean string literals could use CHAR/VARCHAR types now? IIRC, we have some codegen issue on CHAR type, e.g. https://github.com/apache/impala/blob/57f5d612f521c9bb86ec742798365a7b0dad3d49/fe/src/main/java/org/apache/impala/analysis/InPredicate.java#L53-L57 It'd be nice to check if we have performance regression in evaluating InPredicate, LikePredicate, etc. http://gerrit.cloudera.org:8080/#/c/24208/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/24208/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@84 PS8, Line 84: boolean isCoercedProjectForValues = isCoercedProjectForValues(context); Do we still need these isCoercedProjectForValues codes? http://gerrit.cloudera.org:8080/#/c/24208/7/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test: http://gerrit.cloudera.org:8080/#/c/24208/7/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q49.test@a154 PS7, Line 154: > Short answer: This is a regression for Calcite, but it looks like the bug i Thanks for the explanation! Let's investigate this in a separate JIRA. -- To view, visit http://gerrit.cloudera.org:8080/24208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8e61b2555afd81ef52f19431fdd1224d4039c00 Gerrit-Change-Number: 24208 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 04 Jun 2026 08:42:25 +0000 Gerrit-HasComments: Yes
