Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23838 )
Change subject: IMPALA-14564: Remove redundant partition info from Iceberg file descriptors ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/23838/12/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/23838/12/common/thrift/CatalogObjects.thrift@679 PS12, Line 679: // Partition metadata serialized into a FlatBuffer : // (FbIcebergPartition defined in common/fbs/IcebergObjects.fbs). : 9: optional list<binary> partitions > My preference would be to remove this and move to the end as 12: optional l I think we could bump the Catalog version to V3 in CatalogService.thrift to mark the incompatibility. Created IMPALA-15060. http://gerrit.cloudera.org:8080/#/c/23838/12/fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java: http://gerrit.cloudera.org:8080/#/c/23838/12/fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java@67 PS12, Line 67: ByteBuffer newDescBuf = deepCopyByteBuffer(getFbFileDescriptor().getByteBuffer()); : ByteBuffer newMetadataBuf = deepCopyByteBuffer(fbFileMetadata_.getByteBuffer()); : : return new IcebergFi > nit: Done -- To view, visit http://gerrit.cloudera.org:8080/23838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57c2fd6f1ebb636aa9e7ca925413ca51858cbc2a Gerrit-Change-Number: 23838 Gerrit-PatchSet: 13 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 14:55:35 +0000 Gerrit-HasComments: Yes
