Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24389 )
Change subject: IMPALA-15051: Fix IllegalStateException in TableEventExecutor.clear ...................................................................... Patch Set 2: (1 comment) Thanks for adding the tests! The fix makes sense to me. Just have a question. http://gerrit.cloudera.org:8080/#/c/24389/2/fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java File fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java: http://gerrit.cloudera.org:8080/#/c/24389/2/fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java@662 PS2, Line 662: return dbName.toLowerCase() + '.' + tableName.toLowerCase(); It's hard to know whether these are enough, or there are other places that we need this normalization. Is it cleaner if we normalize the db/table names where they flow into our system, e.g. in creating MetastoreEvent instances, catalogd RPCs, etc.? -- To view, visit http://gerrit.cloudera.org:8080/24389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dd210a61e4fbd593a3d30b63b1d879cc0ce2d24 Gerrit-Change-Number: 24389 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 03 Jun 2026 05:28:49 +0000 Gerrit-HasComments: Yes
