[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/24389 )
Change subject: IMPALA-15051: Fix IllegalStateException in TableEventExecutor.clear ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24389/2/fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java File fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java: http://gerrit.cloudera.org:8080/#/c/24389/2/fe/src/main/java/org/apache/impala/catalog/events/DbEventExecutor.java@662 PS2, Line 662: return dbName.toLowerCase() + '.' + tableName.toLowerCase(); > It's hard to know whether these are enough, or there are other places that Have ensured all necessary HEP structs(DBEventExecutor, DbProcessor, TableEventExecutor, TableProcessor) uses normalized names for mapping/lookup. Currently we are normalizing them when needed in catalogd. Agree it would be good to do that when they flow in. But might be hard to handle the names in the nested structure passed to methods both in case of received HMS events processing and catalogd RPCs. Like, In case of table rename, MetastoreEvents.AlterTableEvent#processRename() calls CatalogOpExecutor#renameTableFromEvent(eventId, msTblBefore, msTblAfter, etc) which directly operates on org.apache.hadoop.hive.metastore.api.Table(that can have case sensitive name in it). Similary for catalog exec ddl RPC, different ddl types have different struct and processing path. I mean, we do not have 1 place to extract or set them. IMHO, we can take it as separate jira/task to analyse it. -- To view, visit http://gerrit.cloudera.org:8080/24389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dd210a61e4fbd593a3d30b63b1d879cc0ce2d24 Gerrit-Change-Number: 24389 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 04 Jun 2026 05:11:20 +0000 Gerrit-HasComments: Yes
