Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10797 )
Change subject: IMPALA-7140 (part 6): fetch column stats for LocalTable ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/10797/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/10797/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@395 PS1, Line 395: // TODO(todd): this calculation ends up setting the num_nulls stat hmm, that seems odd. I'll look into it more and file a jira. thx for pointing it out. http://gerrit.cloudera.org:8080/#/c/10797/1/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java: http://gerrit.cloudera.org:8080/#/c/10797/1/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java@57 PS1, Line 57: private static final Logger LOG = Logger.getLogger(Table.class); LocalTable.class -- To view, visit http://gerrit.cloudera.org:8080/10797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6403c2bedf4ee29c5e6f90e947382cb44f46e0c Gerrit-Change-Number: 10797 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Jun 2018 18:03:06 +0000 Gerrit-HasComments: Yes
