Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10797 )
Change subject: IMPALA-7140 (part 6): fetch column stats for LocalTable ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10797/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/10797/1/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@395 PS1, Line 395: // TODO(todd): this calculation ends up setting the num_nulls stat > hmm, that seems odd. I'll look into it more and file a jira. thx for pointi Looked into this one. Partitioning keys are handled differently for stats: compute stats queries skip them and as you've pointed out, they're maintained differently. Given the number of rows in a partition, we should use this for the number of nulls per partition and can sum up over all partitions with a null column. I was in the process of filing a jira, but decided to wait on it to first confirm the behavior. -- To view, visit http://gerrit.cloudera.org:8080/10797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6403c2bedf4ee29c5e6f90e947382cb44f46e0c Gerrit-Change-Number: 10797 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 18:33:23 +0000 Gerrit-HasComments: Yes
