Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 )
Change subject: IMPALA-7163: Implement a state machine for the QueryState class ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10813/2/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/10813/2/be/src/runtime/query-state.h@300 PS2, Line 300: The QueryState is ready for tear-down at this state > I've removed that line since we don't really do any tear down in this patch Actually, to reiterate, we may need to add a new state if we're going to manage ExecResources with this state machine as well. In that case, we'd need to add a new STOPPED state, since on ERROR and CANCELLED, we may have fragment instances still running. -- To view, visit http://gerrit.cloudera.org:8080/10813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec5670a7db83ecae4656d7bb2ea372d3767ba7fe Gerrit-Change-Number: 10813 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Thu, 28 Jun 2018 22:26:34 +0000 Gerrit-HasComments: Yes
