Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24311 )
Change subject: IMPALA-14999: Calcite planner: support Iceberg tables (part 2) ...................................................................... Patch Set 12: Code-Review+1 (6 comments) Only left minor comments, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/24311/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java: http://gerrit.cloudera.org:8080/#/c/24311/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java@114 PS12, Line 114: return agg; I think we should log the exception to know why we are not doing the count-start optimization. http://gerrit.cloudera.org:8080/#/c/24311/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/IcebergCountStarOptimizer.java@208 PS12, Line 208: size Unused variable http://gerrit.cloudera.org:8080/#/c/24311/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteIcebergTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24311/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteIcebergTable.java@83 PS12, Line 83: return false; We should log the exception. http://gerrit.cloudera.org:8080/#/c/24311/12/testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test: http://gerrit.cloudera.org:8080/#/c/24311/12/testdata/workloads/functional-query/queries/QueryTest/iceberg-compound-predicate-push-down.test@272 PS12, Line 272: creates a different predicate Could you please elaborate on this? http://gerrit.cloudera.org:8080/#/c/24311/12/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test: http://gerrit.cloudera.org:8080/#/c/24311/12/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test@299 PS12, Line 299: bool_col which is not being recognized Or is it because we don't push down bare boolean predicates? Filed IMPALA-15077. http://gerrit.cloudera.org:8080/#/c/24311/12/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test@299 PS12, Line 299: XXXXX These will need to be replaced. -- To view, visit http://gerrit.cloudera.org:8080/24311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1854012b1caac63ced292b338d40074db950b42d Gerrit-Change-Number: 24311 Gerrit-PatchSet: 12 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 05 Jun 2026 15:03:34 +0000 Gerrit-HasComments: Yes
