Peter Rozsa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24311 )

Change subject: IMPALA-14999: Calcite planner: support Iceberg tables (part 2)
......................................................................


Patch Set 13: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24311/13/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test
File 
testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test:

http://gerrit.cloudera.org:8080/#/c/24311/13/testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert-default.test@312
PS13, Line 312: # IMPALA-XXXXX: Iceberg should recognized this as a pattern 
that can be used for count start
nit: it should be a real ticket id, same goes for other test files



--
To view, visit http://gerrit.cloudera.org:8080/24311
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1854012b1caac63ced292b338d40074db950b42d
Gerrit-Change-Number: 24311
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 08 Jun 2026 10:46:01 +0000
Gerrit-HasComments: Yes

Reply via email to