Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24417
to look at the new patch set (#2).
Change subject: IMPALA-15081: Clarify timestamp filters
......................................................................
IMPALA-15081: Clarify timestamp filters
impala-profile-tool accepts --min_timestamp and --max_timestamp
filters for profile log entries, but the help text did not explain
that these values are Unix epoch milliseconds. The parse error for
invalid timestamp tokens also did not say which format was expected.
Update the help and flag descriptions to document the expected unit,
and include that unit in timestamp parse errors when filters are
requested. Add a regression test for the error message.
Assisted-by: OpenAI Codex
Change-Id: I58cdd628f90253685d2a5f357a99f3f129db55b9
---
M be/src/util/impala-profile-tool.cc
M tests/observability/test_profile_tool.py
2 files changed, 36 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/24417/2
--
To view, visit http://gerrit.cloudera.org:8080/24417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I58cdd628f90253685d2a5f357a99f3f129db55b9
Gerrit-Change-Number: 24417
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
