Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24417 )
Change subject: IMPALA-15081: Clarify timestamp filters ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24417/2/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24417/2/be/src/util/impala-profile-tool.cc@144 PS2, Line 144: << "--min_timestamp/--max_timestamp filtering.\n"; This message feels slightly ambiguous; the expectation was that the profile timestamp prefix would be Unix epoch milliseconds, and that it's only needed for min/max filtering. Maybe try rewording it a little bit. -- To view, visit http://gerrit.cloudera.org:8080/24417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cdd628f90253685d2a5f357a99f3f129db55b9 Gerrit-Change-Number: 24417 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2026 20:42:29 +0000 Gerrit-HasComments: Yes
