Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24400 )
Change subject: IMPALA-15022: Rework tcmalloc metrics to include tcmalloc metadata ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/24400/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24400/1//COMMIT_MSG@9 PS1, Line 9: Currently, our gperftools tcmalloc metrics like tcmalloc.total-bytes-reserved > nit: wrap commit message at 72 Done http://gerrit.cloudera.org:8080/#/c/24400/1/be/src/util/memory-metrics.h File be/src/util/memory-metrics.h: http://gerrit.cloudera.org:8080/#/c/24400/1/be/src/util/memory-metrics.h@134 PS1, Line 134: class TotalBytesReservedMetric : public IntGauge { > I added FunctionGauge recently for situations like this. I looked into this. I think we should do it, but it is bigger than I thought. FunctionGauge is not a subclass of IntGauge (and it wouldn't really make sense). Various pieces of code rely on IntGauge directly and can't accept a FunctionGauge. However, the code that depends on IntGauge is read only, so I think we can use the base type of FunctionGauge and IntGauge as a ReadOnlyIntGauge type: typedef class ScalarMetric<int64_t, TMetricKind::GAUGE> ReadOnlyIntGauge; Various pieces of code should use that: NegatedGauge, SumGauge, memory metrics, MemTracker, etc. MallocUtil should be returning that type rather than IntGauge. I'll file a JIRA for this. -- To view, visit http://gerrit.cloudera.org:8080/24400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b89193ed0b488dce1498ba630fec91611d7c4fd Gerrit-Change-Number: 24400 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 09 Jun 2026 06:49:54 +0000 Gerrit-HasComments: Yes
