Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24400 )
Change subject: IMPALA-15022: Rework tcmalloc metrics to include tcmalloc metadata ...................................................................... IMPALA-15022: Rework tcmalloc metrics to include tcmalloc metadata Currently, our gperftools tcmalloc metrics like tcmalloc.total-bytes-reserved do not include the malloc metadata. Back when the tcmalloc metrics were added to Impala, gperftools did not expose metrics that would include the malloc metadata. Since then, gperftools has added the generic.total_physical_bytes metric, which includes the malloc metadata. Malloc metadata can be a couple hundred MBs on busy systems, so this is not a major change, but it seems like a slight improvement to our metrics. This changes tcmalloc.physical-bytes-reserved to use the generic.total_physical_bytes metric. It changes tcmalloc.total-bytes-reserved into a derived metric of tcmalloc.physical-bytes-reserved + tcmalloc.pageheap-unmapped-bytes. This brings our metrics in line with the text description from gperftools used for /memz. Testing: - Compared the metrics to the /memz page Change-Id: I5b89193ed0b488dce1498ba630fec91611d7c4fd Reviewed-on: http://gerrit.cloudera.org:8080/24400 Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/memory-metrics.cc M be/src/util/memory-metrics.h M common/thrift/metrics.json 3 files changed, 80 insertions(+), 48 deletions(-) Approvals: Csaba Ringhofer: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/24400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5b89193ed0b488dce1498ba630fec91611d7c4fd Gerrit-Change-Number: 24400 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
