Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24344 )
Change subject: IMPALA-14978: Add runnable Helm values examples ...................................................................... Patch Set 23: (25 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py File .rebuild_open_stack.py: http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py@40 PS23, Line 40: p flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py@43 PS23, Line 43: / flake8: E501 line too long (157 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py@44 PS23, Line 44: , flake8: E501 line too long (116 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py@47 PS23, Line 47: e flake8: E501 line too long (179 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py@48 PS23, Line 48: p flake8: E501 line too long (126 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py@49 PS23, Line 49: o flake8: E501 line too long (194 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py@116 PS23, Line 116: d flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py@154 PS23, Line 154: l flake8: E501 line too long (115 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24344/23/.rebuild_open_stack.py@155 PS23, Line 155: p flake8: E501 line too long (129 > 90 characters) http://gerrit.cloudera.org:8080/#/c/24344/23/be/src/util/memory-metrics.h File be/src/util/memory-metrics.h: http://gerrit.cloudera.org:8080/#/c/24344/23/be/src/util/memory-metrics.h@125 PS23, Line 125: /// process, including that actually in use and free bytes reserved by tcmalloc. Does not line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24344/23/common/fbs/CatalogObjects.fbs File common/fbs/CatalogObjects.fbs: PS23: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/24344/23/common/fbs/IcebergObjects.fbs File common/fbs/IcebergObjects.fbs: PS23: This file is used in communication between impalad and catalogd/statestore. Please make sure impalads can still work with new/old versions of catalogd and statestore. Basically only new fields can be added and should be added at the end of a table definition. https://flatbuffers.dev/flatbuffers_guide_writing_schema.html http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/CatalogObjects.thrift@684 PS23, Line 684: 9: optional list<TIcebergPartition> partitions Changing type of field 'partitions' from list<binary> to list<TIcebergPartition> in TIcebergContentFileStore might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift File common/thrift/hive-1-api/TCLIService.thrift: http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@a63 PS23, Line 63: Removing the enum item TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V8=7 might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@a66 PS23, Line 66: Removing the enum item TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9=8 might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@a69 PS23, Line 69: Removing the enum item TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10=9 might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@a72 PS23, Line 72: Removing the enum item TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V11=10 might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@a96 PS23, Line 96: Removing the enum item TTypeId.INTERVAL_YEAR_MONTH_TYPE=20 might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@a97 PS23, Line 97: Removing the enum item TTypeId.INTERVAL_DAY_TIME_TYPE=21 might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@a98 PS23, Line 98: Removing the enum item TTypeId.TIMESTAMPLOCALTZ_TYPE=22 might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@327 PS23, Line 327: 7: TStringValue stringVal // STRING, LIST, MAP, STRUCT, UNIONTYPE, BINARY, DECIMAL, NULL line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@546 PS23, Line 546: 1: required TProtocolVersion client_protocol = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V6 line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24344/23/common/thrift/hive-1-api/TCLIService.thrift@565 PS23, Line 565: 2: required TProtocolVersion serverProtocolVersion = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V6 line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/24344/23/fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdf.java File fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdf.java: http://gerrit.cloudera.org:8080/#/c/24344/23/fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdf.java@33 PS23, Line 33: import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/24344/23/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java: http://gerrit.cloudera.org:8080/#/c/24344/23/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java@33 PS23, Line 33: import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5c6ab7386bdd791a057b6402e15a82d97c1c381 Gerrit-Change-Number: 24344 Gerrit-PatchSet: 23 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2026 05:08:20 +0000 Gerrit-HasComments: Yes
