Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24344 )
Change subject: IMPALA-14978: Add runnable Helm values examples ...................................................................... Patch Set 26: > Patch Set 25: > > One nit: could we validate values-ldap-example.yaml against the > openldap/openldap chart instead of helm/impala? > Current helm template ... helm/impala -f values-ldap-example.yaml mostly > proves those keys are ignored by Impala, not that the OpenLDAP example itself > is runnable. Good catch, thanks. I updated the test validation in PS26 to render values-ldap-example.yaml against openldap/openldap (with repo add/update), rather than rendering it with helm/impala. This better proves the OpenLDAP example is runnable. -- To view, visit http://gerrit.cloudera.org:8080/24344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5c6ab7386bdd791a057b6402e15a82d97c1c381 Gerrit-Change-Number: 24344 Gerrit-PatchSet: 26 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2026 21:29:59 +0000 Gerrit-HasComments: No
