Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24353 )
Change subject: IMPALA-12956: Add profile summary output ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/24353/7/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24353/7/be/src/util/impala-profile-tool.cc@173 PS7, Line 173: for (const TRuntimeProfileNode& node : tree.nodes) { > nit: Let's add a comment before this loop saying that tree.nodes is a singl Fixed in PS9. Added the pre-order flat-list comment before the loop. http://gerrit.cloudera.org:8080/#/c/24353/7/be/src/util/impala-profile-tool.cc@267 PS7, Line 267: if (SumCounterValuesForParent(tree, "Per Node Profiles", "ScratchBytesWritten", > I think we don't need recursive parsing for this. "Per Node Profiles" is a Fixed in PS9. Bytes Spilled now sums ScratchBytesWritten from direct host children under Execution Profile -> Per Node Profiles. http://gerrit.cloudera.org:8080/#/c/24353/7/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats.expected.summary File testdata/impala-profiles/impala_profile_log_tpcds_compute_stats.expected.summary: http://gerrit.cloudera.org:8080/#/c/24353/7/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats.expected.summary@3 PS7, Line 3: 454fb5fa46498311:3afee31900000000 tarmstrong default QUERY 2020-12-15 20:07:21.735626000 2020-12-15 20:07:23.286577000 1s550ms 15.999ms 54.04 MB 434.92 MB 1824 / 1824 ( 100%) 25 / 25 ( 100%) 142.10 MB 48.74 KB 0 FINISHED OK 1824 default-pool SELECT COUNT(*), ss_sold_date_sk FROM tpcds_parquet.store_sales GROUP BY ss_sold_date_sk > "Bytes Spilled" in current tests are all 0. It'd be nice to add test covera Fixed in PS9. Added non-zero Bytes Spilled coverage for both V1 and V2 profile logs by generating temporary archived profiles with ScratchBytesWritten set. -- To view, visit http://gerrit.cloudera.org:8080/24353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35da958106ffb35b14ef867da50ed23ffda0a45b Gerrit-Change-Number: 24353 Gerrit-PatchSet: 7 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2026 11:45:56 +0000 Gerrit-HasComments: Yes
