Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24353 )
Change subject: IMPALA-12956: Add profile summary output ...................................................................... Patch Set 7: (3 comments) Thanks for updating the patch! I've finished my review. When rebasing this to the current master branch, there is a linking issue that ProgressToString and ParseUtil::ParseMemSpec can't be resolved. Probably due to IMPALA-12955 so we need to update this patch accordingly. http://gerrit.cloudera.org:8080/#/c/24353/7/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24353/7/be/src/util/impala-profile-tool.cc@173 PS7, Line 173: for (const TRuntimeProfileNode& node : tree.nodes) { nit: Let's add a comment before this loop saying that tree.nodes is a single flat list containing every node in the entire profile tree, laid out in pre-order traversal order. http://gerrit.cloudera.org:8080/#/c/24353/7/be/src/util/impala-profile-tool.cc@267 PS7, Line 267: if (SumCounterValuesForParent(tree, "Per Node Profiles", "ScratchBytesWritten", I think we don't need recursive parsing for this. "Per Node Profiles" is a child of "Execution Profile <query id>". Under it there are subtree for each host, and under each host profile there is a ScratchBytesWritten counter. http://gerrit.cloudera.org:8080/#/c/24353/7/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats.expected.summary File testdata/impala-profiles/impala_profile_log_tpcds_compute_stats.expected.summary: http://gerrit.cloudera.org:8080/#/c/24353/7/testdata/impala-profiles/impala_profile_log_tpcds_compute_stats.expected.summary@3 PS7, Line 3: 0 "Bytes Spilled" in current tests are all 0. It'd be nice to add test coverage for non-zero values. You can run some TPC-H queries with "set debug_action=-1:OPEN:[email protected]" to trigger spill-to-disk as more as possible. -- To view, visit http://gerrit.cloudera.org:8080/24353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35da958106ffb35b14ef867da50ed23ffda0a45b Gerrit-Change-Number: 24353 Gerrit-PatchSet: 7 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2026 08:08:36 +0000 Gerrit-HasComments: Yes
