Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23810 )

Change subject: IMPALA-14647: Fix truncate for replicated txn tables always 
delete data
......................................................................


Patch Set 5:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23810/5/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/23810/5/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@734
PS5, Line 734:     msClient.truncateTable(dbName, tableName, partNames, 
validWriteIds, writeId, deleteData);
line too long (93 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia31991baeb2ef8717c387b841b65cff562dbcae0
Gerrit-Change-Number: 23810
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 16 Jun 2026 01:46:25 +0000
Gerrit-HasComments: Yes

Reply via email to