Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23810 )

Change subject: IMPALA-14647: Fix truncate for replicated txn tables always 
delete data
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23810/4/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/23810/4/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@731
PS4, Line 731:       deleteData = !JniCatalog.HIVE_CONF.getBoolean(
For non-transactional tables, we shouldn't use "hive.acid.truncate.usebase". 
This caused the test failures.



--
To view, visit http://gerrit.cloudera.org:8080/23810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia31991baeb2ef8717c387b841b65cff562dbcae0
Gerrit-Change-Number: 23810
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 16 Jun 2026 01:48:07 +0000
Gerrit-HasComments: Yes

Reply via email to