Arnab Karmakar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24474
Change subject: IMPALA-13870: Add operator<< for StringVal to prevent unsafe ptr usage ...................................................................... IMPALA-13870: Add operator<< for StringVal to prevent unsafe ptr usage StringVal buffers are not null-terminated, but manual string construction from ptr/len is error-prone. This change adds a length-safe stream operator that handles NULL values and non-terminated buffers correctly. The operator uses ostream::write(ptr, len) to ensure only len bytes are printed, never relying on null termination. Testing: - Added unit tests including special cases for NULL, empty, non-terminated, and embedded-null cases Change-Id: I2dd226d69fee428b5b38bdbf84dc73de4293c81b --- M be/src/exprs/aggregate-functions-test.cc M be/src/exprs/ai-functions.cc M be/src/exprs/anyval-util.h M be/src/exprs/date-functions-ir.cc M be/src/exprs/expr-test.cc M be/src/exprs/like-predicate.cc M be/src/exprs/timestamp-functions-ir.cc M be/src/exprs/udf-builtins.cc M be/src/udf/udf-debug.h M be/src/udf/udf-test.cc M be/src/udf/udf.h M be/src/udf_samples/udf-sample.cc 12 files changed, 110 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/24474/1 -- To view, visit http://gerrit.cloudera.org:8080/24474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2dd226d69fee428b5b38bdbf84dc73de4293c81b Gerrit-Change-Number: 24474 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]>
