Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24474 )
Change subject: IMPALA-13870: Add operator<< for StringVal to prevent unsafe ptr usage ...................................................................... Patch Set 1: I think the call sites where the direct std::string ctor is called should remain as is. By forcing the stream operator call, you must set up a stringstream just to throw it away after you copy out the string from it. -- To view, visit http://gerrit.cloudera.org:8080/24474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dd226d69fee428b5b38bdbf84dc73de4293c81b Gerrit-Change-Number: 24474 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jun 2026 08:58:42 +0000 Gerrit-HasComments: No
