Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23805 )
Change subject: IMPALA-14637: COMMIT_TXN events should trigger reload for truncate ops ...................................................................... Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23805/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23805/8//COMMIT_MSG@17 PS8, Line 17: Truncate operations don't have new data files so are : missing here, which causes COMMIT_TXN events skip the reloads. Do they always have 0 data files? Can't we catch truncate events by checking that that there is a new base dir, but there are no files written for it? At the first glance the logic looks slightly broken to me, for example what happens if catalogd starts up after the alter but before the commit? http://gerrit.cloudera.org:8080/#/c/23805/8/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/23805/8/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@4470 PS8, Line 4470: MetastoreShim.truncateTable(client.getHiveClient(), TEST_DB_NAME, tblName, : null, tblTxn.validWriteIds, tblTxn.writeId); Is it possible to truncate per partition? If yes, it would make sense to have a test for it. -- To view, visit http://gerrit.cloudera.org:8080/23805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89aac12819f08dd9ed42d5d8b21a96c04b04d75c Gerrit-Change-Number: 23805 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 16 Jun 2026 12:38:25 +0000 Gerrit-HasComments: Yes
