Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23801 )
Change subject: IMPALA-11926: Only load Avro schema in LocalFsTable if the format is Avro ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/23801/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23801/5//COMMIT_MSG@7 PS5, Line 7: IMPALA-11926: Only load Avro schema in LocalFsTable if the format is Avro > Need a blank line after the title. Done http://gerrit.cloudera.org:8080/#/c/23801/5//COMMIT_MSG@21 PS5, Line 21: toTHdfsTable(). > To be consistent with other patches, let keep this Change-Id the last line Done http://gerrit.cloudera.org:8080/#/c/23801/5/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/23801/5/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@161 PS5, Line 161: cmap = ColumnMap.fromMsTable(msTbl); : } : > nit: please remove this comment since the above comment already explains th Done http://gerrit.cloudera.org:8080/#/c/23801/4/tests/query_test/test_avro_schema_resolution.py File tests/query_test/test_avro_schema_resolution.py: http://gerrit.cloudera.org:8080/#/c/23801/4/tests/query_test/test_avro_schema_resolution.py@59 PS4, Line 59: > I see. However, vector is not needed here, it can be omitted from the argum Done http://gerrit.cloudera.org:8080/#/c/23801/5/tests/query_test/test_avro_schema_resolution.py File tests/query_test/test_avro_schema_resolution.py: http://gerrit.cloudera.org:8080/#/c/23801/5/tests/query_test/test_avro_schema_resolution.py@72 PS5, Line 72: # Force a full reload so LocalFsTable.load() is exercised with the new property. > Can we add some data using mixed parquet and avro formats, i.e. some partit Done http://gerrit.cloudera.org:8080/#/c/23801/5/tests/query_test/test_avro_schema_resolution.py@73 PS5, Line 73: self.execute_query("INVALIDATE METADATA {0}".format(tbl)) : # DESCRIBE must succeed: the URL must not be fetched for non-Avro tables. : result = self.execute_query("DESCRIBE {0}".format(tbl)) : assert len(result.data) > 0 : : def test_mixed_format_table_avro_partitions(self, unique_database): : """When any partition is in Avro format, HdfsTable.setAvroSchema() is triggered for : the whole table. Create a table with one Parquet partition and one Avro partition. : Verify that the t > We can simply use self.run_stmt_in_hive(). Done -- To view, visit http://gerrit.cloudera.org:8080/23801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I202665f978401894a1c837293529c06fa4270985 Gerrit-Change-Number: 23801 Gerrit-PatchSet: 7 Gerrit-Owner: Raghav Jindal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Raghav Jindal <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 16 Jun 2026 21:30:53 +0000 Gerrit-HasComments: Yes
