Michael Smith has uploaded a new patch set (#8) to the change originally created by Raghav Jindal. ( http://gerrit.cloudera.org:8080/23801 )
Change subject: IMPALA-11926: Only load Avro schema in LocalFsTable if the format is Avro ...................................................................... IMPALA-11926: Only load Avro schema in LocalFsTable if the format is Avro In local catalog mode LocalFsTable was always trying to load the Avro schema if the avro.schema.url table property was present, even when the table format was not Avro. This made tables unloadable if the URL was invalid even when the table had no Avro data. This is a regression from legacy catalog mode where HdfsTable.setAvroSchema() only loads the Avro schema if the table format is Avro or if there are any Avro partitions. This change moves the loadAvroSchema() call inside the isAvroFormat() if condition check, matching the legacy behavior. Avro schemas for Avro partitions in mixed-format tables are still handled correctly in the toTHdfsTable(). Testing: Added LocalCatalogTest.testNonAvroTableWithInvalidAvroSchemaUrl and TestAvroSchemaResolution.test_non_avro_table_with_avro_schema_url. Assisted-by: Cursor (composer-2) Assisted-by: Claude Sonnet 4.6 (VSCode) Change-Id: I202665f978401894a1c837293529c06fa4270985 --- M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java M tests/query_test/test_avro_schema_resolution.py 3 files changed, 74 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/01/23801/8 -- To view, visit http://gerrit.cloudera.org:8080/23801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I202665f978401894a1c837293529c06fa4270985 Gerrit-Change-Number: 23801 Gerrit-PatchSet: 8 Gerrit-Owner: Raghav Jindal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Raghav Jindal <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
