Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23154 )
Change subject: IMPALA-9846: Enable Aggregated Runtime Profile by Default ...................................................................... Patch Set 30: Posting a summary of the current state and proposed path, to give reviewers a single reference point. Status: Builds have been passing for both V1 and V2 since late January. Since then, new tests have landed in the project from other changes, so a rebase is coming shortly to reconcile those — it is not much, and the 3–5 newly added .test files can be reviewed incrementally. Aside from that rebase, the change is ready for review. The open concern (raised by Csaba): some test lines currently need version-flexible regex, which puts a burden on developers writing future tests. I agree that should not be the long-term expectation. Proposed resolution: For the common case (checking a counter's aggregate), the existing aggregation(SUM, <counter>) helper already lets developers write a single version-agnostic line. For the case Csaba noted — where SUM across instances adds noise and you want a specific value — the current patch uses version-flexible regex, which I agree is not ideal for developers to write going forward. The plan to address this is a small sibling helper (e.g. match_counter) that resolves a counter from the active profile format, introduced as a separate follow-up change (not part of this patch). Once it exists, new tests use the helper instead of version-flexible regex, and we migrate existing lines over gradually — rather than a one-shot rewrite that would risk the work done here. With both helpers available, developers never write profile-version-specific patterns, and the remaining flexible-regex lines stay as special cases only. Importantly, this hybrid approach also gives us a clean, gradual path forward: once the helper layer absorbs version differences, we can transition to a thrift-based test approach later without rewriting the suite again. The test-writing interface stays stable for developers regardless of what the underlying format does. This keeps the merged work intact while addressing the burden concern. I'd appreciate reviewers' thoughts on this direction so we can converge — happy to discuss synchronously as well. -- To view, visit http://gerrit.cloudera.org:8080/23154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If41d6322361fba82c946efd614cc7d28cb1c36e8 Gerrit-Change-Number: 23154 Gerrit-PatchSet: 30 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 17 Jun 2026 08:05:42 +0000 Gerrit-HasComments: No
