Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23154 )
Change subject: IMPALA-9846: Enable Aggregated Runtime Profile by Default ...................................................................... Patch Set 30: > Builds have been passing for both V1 and V2 since late January I saw some cases where I am concerned. from runtime_filters_mt_dop.test: row_regex: RowsReturned: total=7.30K How can this pass with the old profile? >The plan to address this is a small sibling helper (e.g. match_counter) that >resolves a counter from the active profile format, introduced as a separate >follow-up change (not part of this patch). I disagree with the order - the patch should be leaned down to not include trivial test changes before being merged. There may be some tricky exceptions, but replacing most of the existing lines seems fairly mechanical: row_regex: RowsRead: (?:2.43K \(2433\)|total=7.30K \(7300\)) -> match_counter(RowsRead, 2433) For non-aggregated text profiles this doesn't really need Thrift parsing, the exact values can be parsed from text using values in (). This may be actually a more backport friendly way to do it, as in older branches some tests may still use beeswax client that doesn't have Thrift profile. For aggregated profile Thrift is needed, but where we use aggregated profiles we can also assume using HS2 protocol that has Thrift. For current regepxs that contain the exact values in () this looks like relatively simple replace. Another case that seems easily separable are .* removals like in alter-table.test most were removed in https://gerrit.cloudera.org/#/c/23864/ , but there are still many around - these have nothing to do with switching to aggregated profile AFAIK I also see some changes that are simply about new lines in profile (compute-stats.test). Can't these be separated? -- To view, visit http://gerrit.cloudera.org:8080/23154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If41d6322361fba82c946efd614cc7d28cb1c36e8 Gerrit-Change-Number: 23154 Gerrit-PatchSet: 30 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 17 Jun 2026 09:49:03 +0000 Gerrit-HasComments: No
