Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24441 )
Change subject: IMPALA-14685: Fix incorrect outer-to-inner join conversion with NOT predicates ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24441/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/24441/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4346 PS2, Line 4346: e = Expr.pushNegationToOperands(e); nit: I think a comment with a simple example showing why this is necessary would be helpful here, similarly to the one below this line. -- To view, visit http://gerrit.cloudera.org:8080/24441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1737b63765471f155eba268b5798b18277b7733 Gerrit-Change-Number: 24441 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 17 Jun 2026 10:20:18 +0000 Gerrit-HasComments: Yes
