Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24441 )
Change subject: IMPALA-14685: Fix incorrect outer-to-inner join conversion with NOT predicates ...................................................................... Patch Set 3: (1 comment) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24441/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/24441/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4346 PS2, Line 4346: // Push NOT inward (i.e. applying D > nit: I think a comment with a simple example showing why this is necessary Added comment. -- To view, visit http://gerrit.cloudera.org:8080/24441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1737b63765471f155eba268b5798b18277b7733 Gerrit-Change-Number: 24441 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 18 Jun 2026 12:31:21 +0000 Gerrit-HasComments: Yes
