Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24459 )
Change subject: IMPALA-14787: Add support for Redhat 10 and SLES 16 ...................................................................... Patch Set 13: Code-Review-1 (5 comments) Sorry for the blocking vote: there is a nasty little copy-paste omission in impala-config.sh, where base Docker images are specified. Aside from that, the patch would be +2 for me too. Luckily I don't expect the affected line to impact the pre-commit test run at all, so I think that can be started safely. I'll check back in the morning (BUD time) for the fix to supply my +2 vote. Thanks for the understanding. http://gerrit.cloudera.org:8080/#/c/24459/13/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/24459/13/bin/bootstrap_system.sh@90 PS13, Line 90: 8 or 9 Nit: add 10 here http://gerrit.cloudera.org:8080/#/c/24459/10/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/24459/10/bin/bootstrap_toolchain.py@86 PS10, Line 86: OsMapping("sles12", "ec2-package-sles-12") Maybe we can remove SLES 12 as well http://gerrit.cloudera.org:8080/#/c/24459/10/bin/impala-config-java.sh File bin/impala-config-java.sh: http://gerrit.cloudera.org:8080/#/c/24459/10/bin/impala-config-java.sh@22 PS10, Line 22: Redhat 10 only has Java 21 or above Does this mean that all the below options would actually fail on Red Hat 10? Should we guard against them? Another question is whether compiling our Java code with source=1.8 and target=1.17 settings, but using JDK21 would produce code identical with (or similar enough to) code produced on platform with native JDK 17. http://gerrit.cloudera.org:8080/#/c/24459/13/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/24459/13/bin/impala-config.sh@312 PS13, Line 312: 9 This should be 10 http://gerrit.cloudera.org:8080/#/c/24459/12/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/24459/12/bin/jenkins/all-tests.sh@35 PS12, Line 35: # that don't install ninja. : export IMPALA_MAKE_CMD=${IMPALA_MAKE_CMD:-ninja} : > Can we install ninja on all build environments? This is tracked by IMPALA-14756. On most Red Hat derivatives Ninja is available from the CodeReady Builder package repo. There are two issues with this repo (or repo family): 1. They are usually disabled (but they are easy to enable temporarily with the --enablerepo=<repo_id> option) 2. Annoyingly,every single distribution uses a different repo_id for it (Red Hat uses a different repo_id even between their UBI Docker images and their bootable OS images in EC2). I've started collecting the necessary signatures; I'm happy to pass these on to you, or equally happy to push IMPALA-14756 to completion independently of this patch, just let me know which option you prefer. -- To view, visit http://gerrit.cloudera.org:8080/24459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50acc5fbb4968e4310c4f84dde1d5b931b0385ec Gerrit-Change-Number: 24459 Gerrit-PatchSet: 13 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 17 Jun 2026 22:47:42 +0000 Gerrit-HasComments: Yes
